Skip to content

🌱 Bundle renderer refactor webhook service related function and attribute naming #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

🌱 Bundle renderer refactor webhook service related function and attribute naming #1999

merged 2 commits into from
May 28, 2025

Conversation

@perdasilva
Copy link
Contributor

Description

Minor refactor renaming the WebhookServiceGenerator and WebhookService attribute in the cert provider configuration. The naming is not accurate in the sense that the service is not necessarily exclusive to webhooks. In some future, if we want to implement, e.g. APIService support, the same service will be used. These are rather services that are backed by the deployments in described in the CSV.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Per Goncalves da Silva added 2 commits May 28, 2025 13:13
Refactor certprovider WebhookServiceName to ServiceName
351b64d 
Signed-off-by: Per Goncalves da Silva <[email protected]>
Refactor BundleWebhookServiceResourceGenerator to BundleDeploymentSer…
29c5046 
…viceResourceGenerator

Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva requested a review from a team as a code owner May 28, 2025 11:17
@openshift-ci openshift-ci bot requested review from bentito and joelanford May 28, 2025 11:17
@netlify
Copy link

netlify bot commented May 28, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 29c5046
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6836f0b36399dd0008bba715
😎 Deploy Preview https://deploy-preview-1999--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@perdasilva perdasilva changed the title 🌱 Renderer fixups 🌱 Bundle renderer refactor webhook service related function and attribute naming May 28, 2025
@codecov
Copy link

codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.11%. Comparing base (71108b2) to head (29c5046).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1999   +/-   ##
=======================================
  Coverage   69.11%   69.11%           
=======================================
  Files          79       79           
  Lines        7023     7023           
=======================================
  Hits         4854     4854           
  Misses       1887     1887           
  Partials      282      282
Flag Coverage Δ
e2e 43.11% <38.46%> (ø)
unit 59.97% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

camilamacedo86
camilamacedo86 reviewed May 28, 2025
View reviewed changes
internal/operator-controller/rukpak/render/certprovider_test.go
CertName: "cert",
Namespace: "namespace",
CertProvider: nil,
ServiceName: "webhook",
Copy link
Contributor

@camilamacedo86 camilamacedo86 May 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Make sense we could use it for metrics:
See for example:

https://github.com/kubernetes-sigs/kubebuilder/blob/71fc857095565a48980cdfc323126c0cb1c98e7b/testdata/project-v4/config/default/kustomization.yaml#L44-L49

Which will patch: https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/config/default/cert_metrics_manager_patch.yaml

To pass the cert for the metrics server like:

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit ac14a4e into operator-framework:main May 28, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@bentito bentito Awaiting requested review from bentito

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@camilamacedo86 camilamacedo86

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@perdasilva @camilamacedo86